HomePhabricator

[metachronik, charts.e.cash] Correctly calculate cumulative agora usd volume

Description

[metachronik, charts.e.cash] Correctly calculate cumulative agora usd volume

Summary:
The current approach is not actually cumulative, as it shows decreasing cumulative volume with decreasing price.

Calculate the USD value every day so we can properly calculate the cumulative value.

Test Plan:
npm test, CI, check screenshots.

current prod (does not make sense, cumulative volume cannot decrease):

image.png (705×1 px, 93 KB)

after this diff:

image.png (588×1 px, 197 KB)

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D18882

Details

Provenance
bytesofmanAuthored on Wed, Nov 5, 17:54
bytesofmanPushed on Wed, Nov 5, 22:10
Reviewer
Restricted Project
Differential Revision
D18882: [metachronik, charts.e.cash] Correctly calculate cumulative agora usd volume
Parents
rABC4ddd97b95f02: [validation] merge all ConnectBlock debug logging code paths
Branches
Unknown
Tags
Unknown