HomePhabricator

test: Speed up rpc_blockchain.py by removing miniwallet.generate()

Description

test: Speed up rpc_blockchain.py by removing miniwallet.generate()

Summary:

Speed up various tests:

    Remove unused nodes, which only consume time on start/stop
    Remove unused "bug workarounds"
    Remove the need for miniwallet.generate() by adding miniwallet.scan_blocks(). (On my system, with valgrind, generating 105 blocks takes 3.31 seconds. Rescanning 5 blocks takes 0.11 seconds.)

Backport of core#21200.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, sdulfari

Reviewed By: #bitcoin_abc, sdulfari

Differential Revision: https://reviews.bitcoinabc.org/D12432

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Feb 16 2021, 15:27
FabienCommitted on Nov 9 2022, 09:23
FabienPushed on Nov 9 2022, 09:23
Reviewer
Restricted Project
Differential Revision
D12432: test: Speed up rpc_blockchain.py by removing miniwallet.generate()
Parents
rABCf905533957e2: [Cashtab] Patched vertical alignment of NavItems in hamburger menu
Branches
Unknown
Tags
Unknown