HomePhabricator

Fix deprecated ByteSize() for protobuf >= 3.1

Description

Fix deprecated ByteSize() for protobuf >= 3.1

Summary:
Based on the reverted D5386 but accounting on protobuf version to remain
compatible.
Note that autotools will still have the warning.

Test Plan:
With protobuf >= 3.1:

ninja check

Make sure the warning is gone.

Run the gitian builds.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6275

Details

Provenance
FabienAuthored on May 28 2020, 10:03
FabienPushed on May 28 2020, 14:44
Reviewer
Restricted Project
Differential Revision
D6275: Fix deprecated ByteSize() for protobuf >= 3.1
Parents
rABC861bd1645c2c: [backport#15713] Add BroadcastTransaction utility usage in Chain interface
Branches
Unknown
Tags
Unknown
Reverts
D5386: Stop using the deprecated google::protobuf::MessageLite::ByteSize()