HomePhabricator

Replace setInventoryKnown with a rolling bloom filter.
ec73ef37eccfUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Replace setInventoryKnown with a rolling bloom filter.

Mruset setInventoryKnown was reduced to a remarkably small 1000
entries as a side effect of sendbuffer size reductions in 2012.

This removes setInventoryKnown filtering from merkleBlock responses
because false positives there are especially unattractive and
also because I'm not sure if there aren't race conditions around
the relay pool that would cause some transactions there to
be suppressed. (Also, ProcessGetData was accessing
setInventoryKnown without taking the required lock.)

Details

Provenance
Gregory Maxwell <greg@xiph.org>Authored on Nov 26 2015, 05:25
Pieter Wuille <pieter.wuille@gmail.com>Committed on Nov 30 2015, 11:53
deadalnixPushed on May 14 2017, 22:04
Parents
rABCa7751824ce8a: Merge pull request #7103
Branches
Unknown
Tags
Unknown

Event Timeline

Pieter Wuille <pieter.wuille@gmail.com> committed rABCec73ef37eccf: Replace setInventoryKnown with a rolling bloom filter. (authored by Gregory Maxwell <greg@xiph.org>).Nov 30 2015, 11:53