HomePhabricator

[Cashtab] Replace commas as thousands separator with space

Description

[Cashtab] Replace commas as thousands separator with space

Summary:
Large balances should be displayed with some kind of a thousands separator. This is frequently a comma, as in "1,000,000"

However, some countries use the comma as a decimal separator. A simple space, as in "1 000 000" is more universal. Regional customization would be best, but that can wait.

This diffs implements a space as the default thousands separator and adds a unit test to confirm separator is not added to numbers after the decimal place.

Test Plan: npm test

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D9287

Details

Provenance
Joey King <joseph.roy.king@gmail.com>Authored on Mar 1 2021, 23:56
bytesofmanPushed on Mar 2 2021, 13:07
Reviewer
Restricted Project
Differential Revision
D9287: [Cashtab] Replace commas as thousands separator with space
Parents
rABC3af72190a3f5: [Cashtab] URGENT patch balance display bug in Safari
Branches
Unknown
Tags
Unknown