HomePhabricator

Merge #14444: Add compile time checking for cs_main locks which we assert at…

Description

Merge #14444: Add compile time checking for cs_main locks which we assert at run time

Summary:
0089905361 Add compile time checking for cs_main locks which we assert at run time (practicalswift)

Pull request description:

Assert locking requirements at compile-time (`EXCLUSIVE_LOCKS_REQUIRED(foo)`) instead of at run-time (`AssertLockHeld(…)`).

Tree-SHA512: f4965ebf4bb5dbf5e7ed738cacf82c0f6cd55134fb968860bf84a84e29806485617f223910bb8c5461213f1829b0137c64ba1f6d6a2008b3cac3bb3a28df9324

Backport of Core PR14444
https://github.com/bitcoin/bitcoin/pull/14444/

Test Plan:

../configure CXX=clang++ CC=clang
make check

Run teamcity build-werror

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D4225

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Oct 24 2018, 00:32
nakihitoCommitted on Oct 25 2019, 01:58
nakihitoPushed on Oct 25 2019, 01:58
Reviewer
Restricted Owners Package
Differential Revision
D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time
Parents
rABC4db70e1fcd75: Merge #13114: wallet/keystore: Add Clang thread safety annotations for…
Branches
Unknown
Tags
Unknown