HomePhabricator

clean up script_tests -- move segwit recovery into static json

Description

clean up script_tests -- move segwit recovery into static json

Summary:
The script_build generated tests in script_tests are best reserved for
those tests that have transaction signatures in them -- they may need to
be regenerated for some reason as they are sensitive to transaction
contents and hashtype. Though non-signature tests can be done this way,
they unnecessarily add to the (quite large) computational resources used
during script_tests.cpp compilation and cause a warning during build:
variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without

Since segwit recovery tests involve no signatures, they can be moved into
the static parts of the json file.

Test Plan: make check

Reviewers: deadalnix, Mengerian, florian, #bitcoin_abc

Reviewed By: deadalnix, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3416

Details

Provenance
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>Authored on Jun 9 2019, 23:41
markblundebergPushed on Jun 27 2019, 17:40
Reviewer
Restricted Project
Differential Revision
D3416: clean up script_tests -- move segwit recovery into static json
Parents
rABC6feaf4cb627d: Merge #12287: Optimise lock behaviour for GuessVerificationProgress()
Branches
Unknown
Tags
Unknown

Event Timeline

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCf27163f97a47: clean up script_tests -- move segwit recovery into static json (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).Jun 27 2019, 17:40