HomePhabricator

gui: use PACKAGE_NAME in exception message

Description

gui: use PACKAGE_NAME in exception message

Summary: This is a backport of Core PR18646

Test Plan:

diff --git a/src/qt/modaloverlay.cpp b/src/qt/modaloverlay.cpp
index e5f32fe12..c5686cc0d 100644
--- a/src/qt/modaloverlay.cpp
+++ b/src/qt/modaloverlay.cpp
@@ -7,6 +7,7 @@

 #include <chainparams.h>
 #include <qt/guiutil.h>
+#include <util/check.h>

 #include <QPropertyAnimation>
 #include <QResizeEvent>
@@ -197,6 +198,7 @@ void ModalOverlay::showHide(bool hide, bool userRequested) {
 }

 void ModalOverlay::closeClicked() {
+    CHECK_NONFATAL(false);
     showHide(true);
     userClosed = true;
 }

Running bitcoin-qt and clicking Hide in the modal causes the exception dialog to appear. Check that it includes "Bitcoin ABC".

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8928

Details

Provenance
fanquake <fanquake@gmail.com>Authored on Jan 15 2021, 12:23
PiRKCommitted on Jan 15 2021, 12:23
abc-botPushed on Jan 15 2021, 12:29
Reviewer
Restricted Project
Differential Revision
D8928: gui: use PACKAGE_NAME in exception message
Parents
rABC19d226a18966: test: shift coverage from getunconfirmedbalance to getbalances
Branches
Unknown
Tags
Unknown