HomePhabricator

wallet: Don't override signing errors

Description

wallet: Don't override signing errors

Summary:

While reviewing #17204 I noticed that the errors in input_errors from ::SignTransaction where being overridden by CWallet::SignTransaction. For example, a Script related error led to incomplete signature data which led to CWallet::SignTransaction reporting that keys were missing, which was a less precise error than the original one.

Note: in our codebase the errors are overwritten one more time, as a result of a change in D8100. The comment mentions "get proper error messages". None of these error messages seem to be tested at the moment, because removing this block does not cause any test to fail.

This is a backport of core#19568

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D10085

Details

Provenance
Fabian Jahr <fjahr@protonmail.com>Authored on Jul 22 2020, 10:35
PiRKCommitted on Sep 10 2021, 10:10
PiRKPushed on Sep 10 2021, 10:10
Reviewer
Restricted Project
Differential Revision
D10085: wallet: Don't override signing errors
Parents
rABC09c0f3c5929d: rpc: Assert that RPCArg names are equal to CRPCCommand ones (misc)
Branches
Unknown
Tags
Unknown