HomePhabricator

qt: Fix out-of-tree GUI builds
f59dceb44f9bUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

qt: Fix out-of-tree GUI builds

Without this patch:

  • When I compile the GUI from the bitcoin directory itself, it works as expected.
  • When I build the GUI in an out-of-tree build, I cannot get it to select tabs. When I click, say the "Receive" tab nothing happens, the button selects but it doesn't switch the page. The rest - even the debug window - seems to work.

See full discussion here:
https://github.com/bitcoin/bitcoin/pull/7911#issuecomment-212413442

This turned out to be caused by a mismatch in the arguments to moc,
preventing it from finding bitcoin-config.h. Fix this by passing
$(DEFAULT_INCLUDES) to it, which gets set to the appropriate
path by autoconf itself.

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Apr 22 2016, 07:21
deadalnixPushed on May 14 2017, 22:04
Parents
rABC351abf9e0355: Merge #7911: leveldb: integrate leveldb into our buildsystem
Branches
Unknown
Tags
Unknown

Event Timeline

Wladimir J. van der Laan <laanwj@gmail.com> committed rABCf59dceb44f9b: qt: Fix out-of-tree GUI builds (authored by Wladimir J. van der Laan <laanwj@gmail.com>).Apr 22 2016, 07:21