HomePhabricator

scripted-diff: Wallet: Rename incorrectly named *UsedDestination

Description

scripted-diff: Wallet: Rename incorrectly named *UsedDestination

Summary:

These functions are used to mark/check if a key of our own has been used to spend (and only for avoid-reuse wallets), which has nothing to do with the destination/address itself.
Give them more accurate names to avoid confusion.

-BEGIN VERIFY SCRIPT-
sed -i -e 's/UsedDestination/SpentKey/g' $(git grep -l 'UsedDestination' ./src)
-END VERIFY SCRIPT-

This is a backport of Core PR18193

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D8767

Details

Provenance
Luke Dashjr <luke-jr+git@utopios.org>Authored on Jan 3 2021, 08:45
PiRKCommitted on Jan 3 2021, 08:46
abc-botPushed on Jan 3 2021, 08:52
Reviewer
Restricted Project
Differential Revision
D8767: scripted-diff: Wallet: Rename incorrectly named *UsedDestination
Parents
rABC7f8780957e52: add: test that transactions expire from mempool
Branches
Unknown
Tags
Unknown