HomePhabricator

[backport#17999 2/2] refactor: Use psbt forward declaration

Description

[backport#17999 2/2] refactor: Use psbt forward declaration

Summary:
Also clean up forward other forward declarations in interfaces/wallet.h with !sort

Original motivation for this change was to fix a circular dependencies lint
error: "interfaces/chain.h -> interfaces/wallet.h -> psbt -> node/transaction
-> node/context -> interfaces/chain.h" from an earlier commit in this PR adding
a "interfaces/chain.h -> interfaces/wallet.h" include. Now, the wallet include
is no longer added, but it is still good to clean up the psbt include for
efficiency, and to sort the forward declarations.


Depends on D6995

Backport of Core PR17999 part [2/2] : https://github.com/bitcoin/bitcoin/pull/17999/commits/3ce16ad2f91d1e2edc7e7bdc5a19f72aa8c3e739

Test Plan:

ninja all check check-functional

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7962

Details

Provenance
Russell Yanofsky <russ@yanofsky.org>Authored on Fri, Oct 16, 19:55
majcostaCommitted on Fri, Oct 16, 19:55
abc-botPushed on Fri, Oct 16, 20:01
Reviewer
Restricted Project
Differential Revision
D7962: [backport#17999 2/2] refactor: Use psbt forward declaration
Parents
rABCd44cb2f96784: [backport#16743] refactor: move LoadChainTip/RelayBlocks under CChainState
Branches
Unknown
Tags
Unknown