HomePhabricator
Diffusion Bitcoin ABC f9ed1e8d3ff8

blockfilter: Remove sharp edge (uninitialized m_filter_type) when using the…
f9ed1e8d3ff8
Actions

Description

blockfilter: Remove sharp edge (uninitialized m_filter_type) when using the compiler-generated constructor for BlockFilter

Summary:
backport of core PR 15532 (commit 82c3b3f8e)

Note: due to BOOST_CHECK_EQUAL barfing on the new enum class uint8_t,
I've switched that test to also use just BOOST_CHECK.

Test Plan: make check

Reviewers: #bitcoin_abc, deadalnix, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: Mengerian, jasonbcox

Maniphest Tasks: T589

Differential Revision: https://reviews.bitcoinabc.org/D2879

Details

Provenance
practicalswift <practicalswift@users.noreply.github.com>Authored on May 4 2019, 17:33
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>Committed on May 4 2019, 17:51
markblundebergPushed on May 4 2019, 17:51
Reviewer
Restricted Project
Differential Revision
D2879: blockfilter: Remove sharp edge (uninitialized m_filter_type) when using the compiler-generated constructor for BlockFilter
Parents
rABC7a78809ec2f9: blockfilter: Refactor and add tests for BlockFilter construction
Branches
Unknown
Tags
Unknown

Event Timeline

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCf9ed1e8d3ff8: blockfilter: Remove sharp edge (uninitialized m_filter_type) when using the… (authored by practicalswift <practicalswift@users.noreply.github.com>).May 4 2019, 17:51

Changes (3)

PathSize
src/
test/

rABCf9ed1e8d3ff8

View Options

src/blockfilter.cpp

Loading...
View Options

src/blockfilter.h

Loading...
View Options

src/test/blockfilter_tests.cpp

Loading...