HomePhabricator

[Cashtab] Remove render-only snapshot tests

Description

[Cashtab] Remove render-only snapshot tests

Summary:
Not enough thought has gone into how and why snapshot testing occurs in Cashtab. Snapshot testing is an easy way to get coverage for components that otherwise appear untested. However, a snapshot test that is only gauging whether or not a component will render is effectively the same as checking whether or not npm run build succeeds.

The right way to test each component is to work in real situations and integration tests. QRCode.test.js is a good model for this.

Boilerplate snapshot tests have not caught any errors for the last 2 years but have caused a lot of headaches in dev review. So, lose render-only snapshot tests. Make sure snapshots that are kept are up to date (BCH -> XEC).

Test Plan: npm test

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D15034

Details

Provenance
bytesofmanAuthored on Dec 22 2023, 00:14
bytesofmanPushed on Dec 22 2023, 17:36
Reviewer
Restricted Project
Differential Revision
D15034: [Cashtab] Remove render-only snapshot tests
Parents
rABC0854099a3828: [ecashaddrjs] Copy all files to support prepublish command in CI
Branches
Unknown
Tags
Unknown