HomePhabricator

[avalanche] Delay polling the conflicting transactions

Description

[avalanche] Delay polling the conflicting transactions

Summary:
THe actual behavior is to poll for the mempool transactions and the conflicting transactions. The latter is actually not strictly needed: if a conflicting transaction exists, then there is an associated transaction living in the mempool. Because we pull back the conflicting transactions if the mempool one is rejected, it will naturally be polled as well when it reached the mempool.

This simplifies the logic and avoids some edge cases because mempool transactions have computed all the properties to check if they will fit in a block, despite conflicting transactions don't.

Test Plan:

ninja check-extended

Reviewers: #bitcoin_abc, roqqit

Reviewed By: #bitcoin_abc, roqqit

Subscribers: roqqit

Differential Revision: https://reviews.bitcoinabc.org/D18004

Details

Provenance
FabienAuthored on Mon, Apr 28, 10:17
FabienPushed on Thu, May 1, 20:03
Reviewer
Restricted Project
Differential Revision
D18004: [avalanche] Delay polling the conflicting transactions
Parents
rABC029da727864b: [avalanche] Fix incomplete testing of contenders when staking rewards are active
Branches
Unknown
Tags
Unknown