HomePhabricator

Bump univalue subtree

Description

Bump univalue subtree

Summary:

This bumps the univalue subtree and changes two lines of our code. Apart from the get_int -> getInt change, this is mostly a rebase of #15975, which was closed back then.

However, given the numerous UniValue copy bugs and performance regressions in the past years, I think it makes sense to finally go through with the changes and disable potentially expensive implicit UniValue copies, which may cause OOM.

The changes here are not strictly required for that, but make future changes less verbose and easier to review.

Backport of core#25249.

Depends on D16273.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D16274

Details

Provenance
FabienAuthored on Jun 4 2024, 16:03
FabienPushed on Jun 4 2024, 19:26
Reviewer
Restricted Project
Differential Revision
D16274: Bump univalue subtree
Parents
rABC80d4cbd1c5f5: scripted-diff: Use getInt<T> over get_int/get_int64
Branches
Unknown
Tags
Unknown