HomePhabricator

[Cashtab] Patch bug in fee calculation for token creation

Description

[Cashtab] Patch bug in fee calculation for token creation

Summary: Bug in how transaction fees are calculated in token creation previously concealed by the high default app fee of 5 sat/byte. Reducing the fee caused token creation txs to fail. Investigating, bug in how default fee applied (should be in base units i.e. sats).

Test Plan:
npm test; note unit test has new mock raw hex as previous tx, while valid, did not correspond to app fee setting.
npm start
Create a token

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D9586

Details

Provenance
Joey King <joseph.roy.king@gmail.com>Authored on May 26 2021, 17:17
bytesofmanPushed on May 27 2021, 16:05
Reviewer
Restricted Project
Differential Revision
D9586: [Cashtab] Patch bug in fee calculation for token creation
Parents
rABCbe9b4b0ab750: Split cs_main lock when sending getdata between inv types
Branches
Unknown
Tags
Unknown