HomePhabricator

Block unsafe fs::path std::string conversion calls [7/7]

Description

Block unsafe fs::path std::string conversion calls [7/7]

Summary:
This concludes backport of core#22937 [2g/2g]
https://github.com/bitcoin/bitcoin/pull/22937/commits/6544ea5035268025207d2402db2f7d90fde947a6

This commit disallows passing a std::string to fs::path, building on previous commits which removed all such calls. This is because the behavior of this constructor on windows will be more complicated and can mangle path strings after the transition from boost::filesystem to std::filesystem in core#20744 .

Depends on D10800

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10801

Details

Provenance
PiRKAuthored on Jan 10 2022, 10:24
PiRKPushed on Jan 11 2022, 12:25
Reviewer
Restricted Project
Differential Revision
D10801: Block unsafe fs::path std::string conversion calls [7/7]
Parents
rABC3758d64b9033: convert unsafe fs::path std::string conversion calls [6/7] (wallet)
Branches
Unknown
Tags
Unknown