HomePhabricator

test: Get rid of default wallet hacks

Description

test: Get rid of default wallet hacks

Summary:

  • Get rid of hardcoded wallet "" names and -wallet="" args
  • Get rid of setup_nodes (-wallet, -nowallet, -disablewallet) argument rewriting

Motivation:

  • Simplify test framework behavior so it's easier to write new tests without having arguments mangled by the framework
  • Make tests more readable, replacing unexplained "" string literals with default_wallet_name references
  • Make it trivial to update default wallet name and wallet data filename for sqlite #19077 testing
  • Stop relying on -wallet arguments to create wallets, so it is easy to change -wallet option in the future to only load existing wallets not create new ones (to avoid accidental wallet creation, and encourage use of wallet encryption and descriptor features)

This is a backport of core#20034 [2/2]
https://github.com/bitcoin/bitcoin/pull/20034/commits/c1585bca8dae01dee6a1dd8eadae2f8b100503df

Depends on D10421

Test Plan: ninja check-functional-extended

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Subscribers: majcosta

Differential Revision: https://reviews.bitcoinabc.org/D10422

Details

Provenance
Russell Yanofsky <russ@yanofsky.org>Authored on Sep 29 2020, 00:24
PiRKCommitted on Nov 3 2021, 07:09
PiRKPushed on Nov 3 2021, 07:09
Reviewer
Restricted Project
Differential Revision
D10422: test: Get rid of default wallet hacks
Parents
rABC975d0e385a1a: test, refactor: add default_wallet_name and wallet_data_filename variables
Branches
Unknown
Tags
Unknown