[avalanche] Make the GetAvalancheVoteForBlock method const
Summary: Getting a vote should not change the PeerManager, so enforce it by marking it const.
Test Plan:
ninja all check
Reviewers: #bitcoin_abc, PiRK
Reviewed By: #bitcoin_abc, PiRK
Differential Revision: https://reviews.bitcoinabc.org/D12967