HomePhabricator

Bugfix: only track UTXO modification after lookup
02bced16615fUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Bugfix: only track UTXO modification after lookup

Otherwise, if CCoinsViewCache::ModifyCoins throws an exception in between
setting hasModifier and constructing the CCoinsModifier, the cache ends up
in an inconsistent state, resulting in an assert failure in the next
modification.

Bug discovered by Wladimir J. van der Laan.

Details

Provenance
Pieter Wuille <pieter.wuille@gmail.com>Authored on Jan 4 2015, 16:15
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGINGa99ef7d3533b: Merge pull request #5505
Branches
Unknown
Tags
Unknown

Event Timeline

Pieter Wuille <pieter.wuille@gmail.com> committed rSTAGING02bced16615f: Bugfix: only track UTXO modification after lookup (authored by Pieter Wuille <pieter.wuille@gmail.com>).Jan 4 2015, 16:16