HomePhabricator

[SECP256K1] Add valgrind check to travis

Description

[SECP256K1] Add valgrind check to travis

Summary:

As discussed in #687
This adds valgrind check to the repo.

It doesn't run on recovery+ecdh because of the time.
No openssl because of uninitialized mem.
I debated between with and without ASM, but decided with ASM because it
might be more fragile(?).

I wasn't sure if I should pass -DVALGRIND via CFLAGS or CPPFLAGS, it
seems like because this is only C then there shouldn't even be CPPFLAGS
but looks like we use CPPFLAGS in other places for the preprocessor
definitions.

If people are worried about the time it takes we can mark it as
allow_failure although I don't think it's a problem here because there's
only a handful of PRs and they're usually open for weeks.

Backport of secp256k1 PR690.

Depends on D5429, D5430 and D5431.

Test Plan:
Run the Travis build (see
https://travis-ci.org/Fabcien/secp256k1/builds/658345685).

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5433

Details

Provenance
Elichai Turkel <elichai.turkel@gmail.com>Authored on Nov 7 2019, 19:31
FabienCommitted on Mar 6 2020, 18:23
FabienPushed on Mar 6 2020, 19:43
Reviewer
Restricted Project
Differential Revision
D5433: [SECP256K1] Add valgrind check to travis
Parents
rSTAGING9638eb281f67: [SECP256K1] Request --enable-experimental for the multiset module
Branches
Unknown
Tags
Unknown