HomePhabricator

Regression test for ResendWalletTransactions
0f5954c434fdUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Regression test for ResendWalletTransactions

Adds a regression test for the wallet's ResendWalletTransactions function, which uses a new, hidden RPC command "resendwallettransactions."

I refactored main's Broadcast signal so it is passed the best-block time, which let me remove a global variable shared between main.cpp and the wallet (nTimeBestReceived).

I also manually tested the "rebroadcast unconfirmed every half hour or so" functionality by:

  1. Running bitcoind -connect=0.0.0.0:8333
  2. Creating a couple of send-to-self transactions
  3. Connect to a peer using -addnode
  4. Waited a while, monitoring debug.log, until I see:
2015-03-23 18:48:10 ResendWalletTransactions: rebroadcast 2 unconfirmed transactions

One last change: don't bother putting ResendWalletTransactions messages in debug.log unless unconfirmed transactions were actually rebroadcast.

Details

Provenance
Gavin Andresen <gavinandresen@gmail.com>Authored on Mar 23 2015, 17:47
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGING8d2fbfa49141: Merge pull request #5681
Branches
Unknown
Tags
Unknown

Event Timeline

Gavin Andresen <gavinandresen@gmail.com> committed rSTAGING0f5954c434fd: Regression test for ResendWalletTransactions (authored by Gavin Andresen <gavinandresen@gmail.com>).Mar 24 2015, 19:29