HomePhabricator

Don't create empty transactions when reading corrupted wallet
16ec9044d1f2Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Don't create empty transactions when reading corrupted wallet

The current transaction loading code is not exception safe.
An exception during deserialization causes an empty transaction
to be left behind in the wallet.

Fix this by building the transaction separately and adding
it only to the wallet at the end.

Fixes #3333.

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Dec 16 2013, 16:17
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGING93a7861d719a: Merge pull request #3425
Branches
Unknown
Tags
Unknown

Event Timeline

Wladimir J. van der Laan <laanwj@gmail.com> committed rSTAGING16ec9044d1f2: Don't create empty transactions when reading corrupted wallet (authored by Wladimir J. van der Laan <laanwj@gmail.com>).Dec 16 2013, 16:36