HomePhabricator

travis: Don't disable writing ccache for pull-requests
174023c9b008Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

travis: Don't disable writing ccache for pull-requests

This was doing more harm than good. The original intention was to speed up
builds, since a PR's ccache results will be thrown away anyway.

However, each PR maintains its own cache, so disabling writes means that
subsequent pushes don't benefit from the fresh cache. This is significant when
(for example) many headers are touched in a PR, then the PR is updated. With
this change, the updated PR will take advantage of the cache generated during
the PR's previous build.

Details

Provenance
Cory Fields <cory-nospam-@coryfields.com>Authored on Apr 26 2016, 05:17
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGINGcf77fcdb1fe5: travis: drop MAKEJOBS=2 for windows compilers
Branches
Unknown
Tags
Unknown

Event Timeline

Cory Fields <cory-nospam-@coryfields.com> committed rSTAGING174023c9b008: travis: Don't disable writing ccache for pull-requests (authored by Cory Fields <cory-nospam-@coryfields.com>).Apr 26 2016, 06:25