HomePhabricator

prevector: destroy elements only via erase()
1e2c29f2632cUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

prevector: destroy elements only via erase()

Fixes a bug in which pop_back did not call the deleted item's destructor.

Using the most general erase() implementation to implement all the others
prevents similar bugs because the coupling between deallocation and destructor
invocation only needs to be maintained in one place.
Also reduces duplication of complex memmove logic.

Details

Provenance
Kaz Wesley <keziahw@gmail.com>Authored on Apr 13 2016, 17:09
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGING73fc922ed643: Merge #7603: Build System: Use PACKAGE_TARNAME in NSIS script
Branches
Unknown
Tags
Unknown

Event Timeline

Kaz Wesley <keziahw@gmail.com> committed rSTAGING1e2c29f2632c: prevector: destroy elements only via erase() (authored by Kaz Wesley <keziahw@gmail.com>).Apr 16 2016, 15:05