Diffusion Bitcoin ABC staging 1e98fdfb6b0b

Remove reclarations of read_json, create a dedicated header instead
1e98fdfb6b0b
Actions

Description

Remove reclarations of read_json, create a dedicated header instead

Summary: As per title. Declaring things at a distance makes the code hard to follow and fragile.

Test Plan:

make check
ninja

Reviewers: #bitcoin_abc, schancel

Reviewed By: #bitcoin_abc, schancel

Subscribers: teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1246

Details

Provenance

deadalnix	Authored on Apr 5 2018, 12:28
deadalnix	Pushed on Apr 8 2018, 14:57

Reviewer

Restricted Project

Differential Revision

D1246: Remove reclarations of read_json, create a dedicated header instead

Parents

rSTAGING4642a5e9b468: Enable benchmark building by default and fix benchmarks for gcc 6+

Branches

Unknown

Tags

Unknown

Event Timeline

deadalnix committed rSTAGING1e98fdfb6b0b: Remove reclarations of read_json, create a dedicated header instead (authored by deadalnix).Apr 8 2018, 14:50

Changes (8)

Path

Size

src/

Makefile.test.include

test/

transaction_tests.cpp

rSTAGING1e98fdfb6b0b

View Options

src/Makefile.test.include

View Options

src/test/CMakeLists.txt

View Options

src/test/base58_tests.cpp

View Options

src/test/jsonutil.cpp

View Options

src/test/jsonutil.h

View Options

src/test/script_tests.cpp

View Options

src/test/sighash_tests.cpp

View Options

src/test/transaction_tests.cpp

Remove reclarations of read_json, create a dedicated header instead1e98fdfb6b0bActions

Description

Details

Event Timeline

Changes (8)

rSTAGING1e98fdfb6b0b

src/Makefile.test.include

src/test/CMakeLists.txt

src/test/base58_tests.cpp

src/test/jsonutil.cpp

src/test/jsonutil.h

src/test/script_tests.cpp

src/test/sighash_tests.cpp

src/test/transaction_tests.cpp

Remove reclarations of read_json, create a dedicated header instead
1e98fdfb6b0b
Actions