HomePhabricator

[QT] Don't ask for a passphrase to getnewaddress.
20469d83dd2fUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

[QT] Don't ask for a passphrase to getnewaddress.

With an encrypted wallet the GUI was prompting for a passphrase every time
the user requested a new address. This is unnecessary, increases the
exposure to keyboard sniffers, and discourages using fresh addresses for
every transaction.

Instead only prompt for a passphrase when the keypool runs out, also call
the new address function with the flag that prevents reuse.

Thanks to AlexNagy on IRC for pointing this out and who wouldn't take any
lip from a curmudgeonly developer and insisted on what he knew to be true.

Details

Provenance
Gregory Maxwell <greg@xiph.org>Authored on Aug 16 2013, 04:53
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGINGb60012f2b677: Merge pull request #2872 from Diapolo/GUI_wallet
Branches
Unknown
Tags
Unknown

Event Timeline

Gregory Maxwell <greg@xiph.org> committed rSTAGING20469d83dd2f: [QT] Don't ask for a passphrase to getnewaddress. (authored by Gregory Maxwell <greg@xiph.org>).Aug 23 2013, 19:01