HomePhabricator

RPC, cosmetic: push down ReadHTTPStatus() calls into ReadHTTP() callers
2306dc4b760dUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

RPC, cosmetic: push down ReadHTTPStatus() calls into ReadHTTP() callers

ReadHTTPStatus() is currently overloaded: In client mode, it properly parses
and receives an HTTP status line. In server mode, it incorrectly parses the
HTTP request line as an HTTP status line.

This server mode bug has never mattered, because the RPC server never
cared about the URI (path) provided in the HTTP request. That will change in
the future, so go ahead and begin fixing the problem.

This patch is cosmetic, and should result in NO behavior changes.

Further renames:
ReadHTTPHeader -> ReadHTTPHeaders
ReadHTTP -> ReadHTTPMessage

Details

Provenance
Jeff Garzik <jgarzik@exmulti.com>Authored on Nov 4 2012, 21:06
Jeff Garzik <jgarzik@redhat.com>Committed on Nov 4 2012, 21:06
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGINGa56d3f8a10e3: Merge pull request #1971 from sipa/bugfix_norelayspent
Branches
Unknown
Tags
Unknown

Event Timeline

Jeff Garzik <jgarzik@redhat.com> committed rSTAGING2306dc4b760d: RPC, cosmetic: push down ReadHTTPStatus() calls into ReadHTTP() callers (authored by Jeff Garzik <jgarzik@exmulti.com>).Nov 4 2012, 21:06