HomePhabricator

Merge #10537: Few Minor per-utxo assert-semantics re-adds and tweak

Description

Merge #10537: Few Minor per-utxo assert-semantics re-adds and tweak

Summary:
9417d7a33 Be much more agressive in AccessCoin docs. (Matt Corallo)
f58349ca8 Restore some assert semantics in sigop cost calculations (Matt Corallo)
3533fb4d3 Return a bool in SpendCoin to restore pre-per-utxo assert semantics (Matt Corallo)
ec1271f2b Remove useless mapNextTx lookup in CTxMemPool::TrimToSize. (Matt Corallo)

Tree-SHA512: 158a4bce063eac93e1d50709500a10a7cb1fb3271f10ed445d701852fce713e2bf0da3456088e530ab005f194ef4a2adf0c7cb23226b160cecb37a79561f29ca

Backport of Core PR10537
https://github.com/bitcoin/bitcoin/pull/10537/

Test Plan:

make check
test_runner.py

Reviewers: deadalnix, Fabien, jasonbcox, markblundeberg, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: Fabien, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3542

Details

Provenance
Pieter Wuille <pieter.wuille@gmail.com>Authored on Jun 21 2017, 01:18
nakihitoCommitted on Sep 9 2019, 18:18
nakihitoPushed on Sep 10 2019, 00:26
Reviewer
Restricted Owners Package
Differential Revision
D3542: Merge #10537: Few Minor per-utxo assert-semantics re-adds and tweak
Parents
rSTAGING4dc32c990aa6: Merge #12928: qt: Initialize non-static class members that were previously…
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/11174