HomePhabricator

Do not write to wallet during LoadWallet
2f15e86a68abUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Do not write to wallet during LoadWallet

When debugging another issue, I found a hang-during-startup race condition due to
LoadWallet calling SetMinVersion (via LoadCryptedKey).

Writing to the file that you're in the process of reading is a bad idea.

Details

Provenance
Gavin Andresen <gavinandresen@gmail.com>Authored on May 2 2013, 16:43
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGINGeef2091fe9ee: Merge pull request #2595 from sipa/noannloc
Branches
Unknown
Tags
Unknown

Event Timeline

Gavin Andresen <gavinandresen@gmail.com> committed rSTAGING2f15e86a68ab: Do not write to wallet during LoadWallet (authored by Gavin Andresen <gavinandresen@gmail.com>).May 2 2013, 16:43