Merge #14556: qt: fix confirmed transaction labeled "open"
30fdbefb9de0
Actions

Description

Merge #14556: qt: fix confirmed transaction labeled "open"

Summary:
PR14556 backport https://github.com/bitcoin/bitcoin/pull/14556/files
fb3ce75807c50055a97f573fc72bf44d997ea218 Don't label transactions "Open" while catching up (Hennadii Stepanov)

Pull request description:

Fix #13299.

Since the default `nSequence` is `0xFFFFFFFE` and locktime is enabled, the checking `wtx.is_final` is meaningless until the syncing has completed (ref: #1026).

This PR makes the wallet mark a transaction "Unconfirmed" instead of misleading "Open for NNN more blocks" when syncing after a period of being offline.

Before this PR (with the issue):
![screenshot from 2018-12-12 15-56-23](https://user-images.githubusercontent.com/32963518/49874288-cdd06880-fe26-11e8-8441-f3ceb479611b.png)

With this PR (the issue has been resolved):
![screenshot from 2018-12-12 15-54-41](https://user-images.githubusercontent.com/32963518/49874336-e9d40a00-fe26-11e8-8c05-9aeee2eb1bba.png)

Depends on D3489

Test Plan:
make check
test_bitcoin-qt

Reviewers: deadalnix, Fabien, jasonbcox, #bitcoin_abc

Reviewed By: Fabien, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3491

Details

Provenance

Wladimir J. van der Laan <laanwj@gmail.com>	Authored on Jan 15 2019, 16:25
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>	Committed on Jul 1 2019, 20:23
jasonbcox	Pushed on Jul 1 2019, 21:35

Reviewer

Restricted Project

Differential Revision

D3491: Merge #14556: qt: fix confirmed transaction labeled "open"

Parents