HomePhabricator

[backport#12916] Introduce BigEndian wrapper and use it for netaddress ports

Description

[backport#12916] Introduce BigEndian wrapper and use it for netaddress ports

Summary:
This is another small improvement taken from #10785.

Instead of manually converting from/to BE format in the CService serializer, provide a generic way in serialize.h to serialize BE data (only 16 bits for now).


This is a backport of Core PR12916

Test Plan:

ninja check check-functional

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D5799

Details

Provenance
Pieter Wuille <pieter.wuille@gmail.com>Authored on Apr 8 2018, 16:39
majcostaCommitted on Apr 22 2020, 17:05
majcostaPushed on Apr 22 2020, 18:47
Reviewer
Restricted Project
Differential Revision
D5799: [backport#12916] Introduce BigEndian wrapper and use it for netaddress ports
Parents
rSTAGING763b275496b2: Docs: Modify policy to not translate command-line help
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/19023