HomePhabricator

Merge #8665: Assert all the things!

Description

Merge #8665: Assert all the things!

Summary:
4d51e9b Assert ConnectBlock block and pIndex are the same block (NicolasDorier)
972714c pow: GetNextWorkRequired never called with NULL pindexLast (Daniel Cousens)
cc44c8f ContextualCheckBlockHeader should never have pindexPrev to NULL (NicolasDorier)

Tree-SHA512: 7cc568bf9417267c335f21ec3d1505b26e56e5b3d5f4d3dbb555279489800aaa65a3bcd7bc376e274dd102912aec16ddbb18de2e2060b2667b41eb979cd9321e

Backport of Core PR 8665
https://github.com/bitcoin/bitcoin/pull/8665/files

Test Plan:
make check
test_runner.py

Reviewers: deadalnix, Fabien, #bitcoin_abc

Reviewed By: Fabien, #bitcoin_abc

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2722

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Mar 14 2017, 09:37
jasonbcoxCommitted on Mar 22 2019, 19:43
jasonbcoxPushed on Mar 22 2019, 19:44
Reviewer
Restricted Project
Differential Revision
D2722: Merge #8665: Assert all the things!
Parents
rSTAGING737ff23ed292: [secp256k1] fix java secp256k1 test
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/7798