HomePhabricator

[CMAKE] Fix scope issue in the remove_<lang>_compiler_flags() functions

Description

[CMAKE] Fix scope issue in the remove_<lang>_compiler_flags() functions

Summary:
The CMAKE_<LANG>_FLAGS where not propagated to the parent scope.
The configuration specific variables were correctly scoped if a
configuration is defined, which is our default, but invalid if unset.

Test Plan:

ninja check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D4584

Details

Provenance
FabienAuthored on Nov 29 2019, 15:46
FabienPushed on Dec 2 2019, 16:39
Reviewer
Restricted Project
Differential Revision
D4584: [CMAKE] Fix scope issue in the remove_<lang>_compiler_flags() functions
Parents
rSTAGINGc1ff716fb035: Rationalize lock anotation in validation code
Branches
Unknown
Tags
Unknown