HomePhabricator

Make -proxy set all network types, avoiding a connect leak.
3c777141349aUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Make -proxy set all network types, avoiding a connect leak.

Previously -proxy was not setting the proxy for IsLimited networks, so
if you set your configuration to be onlynet=tor you wouldn't get an
IPv4 proxy set.

The payment protocol gets its proxy configuration from the IPv4 proxy,
and so it would experience a connection leak.

This addresses issue #5355 and also clears up a cosmetic bug where
getinfo proxy output shows nothing when onlynet=tor is set.

Details

Provenance
Gregory Maxwell <greg@xiph.org>Authored on Nov 23 2014, 23:12
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGINGcbf28c6619fe: Merge pull request #5350
Branches
Unknown
Tags
Unknown

Event Timeline

Gregory Maxwell <greg@xiph.org> committed rSTAGING3c777141349a: Make -proxy set all network types, avoiding a connect leak. (authored by Gregory Maxwell <greg@xiph.org>).Nov 23 2014, 23:17