HomePhabricator

Fixed bug in UnwindBlock where child blocks do not have proper parent flags set

Description

Fixed bug in UnwindBlock where child blocks do not have proper parent flags set

Summary:
Fixed a typo introduced in my fix from 4a9b35aa3

Important note: There is unintuitive behavior now documented in the test in the form of NOTE comments. The order of calling parkblock and invalidateblock impacts the chaintip status.

Test Plan:
test_runner.py abc-parkedchain
The new test fails without the fix and passes with it.

Reviewers: deadalnix, schancel, #bitcoin_abc, Fabien

Reviewed By: deadalnix, #bitcoin_abc, Fabien

Subscribers: teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1987

Details

Provenance
jasonbcoxAuthored on Nov 1 2018, 16:58
jasonbcoxPushed on Nov 1 2018, 17:07
Reviewer
Restricted Project
Differential Revision
D1987: Fixed bug in UnwindBlock where child blocks do not have proper parent flags set
Parents
rSTAGINGcf7e38a4620a: Add test cases for CBlockIndex class
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/5618, tag: phabricator/base/5617, tag: phabricator/base/5616