HomePhabricator

Add support for AND, OR and XOR opcodes

Description

Add support for AND, OR and XOR opcodes

Summary:
These opcodes are gated by a flag and compute what you'd expect for
binary ops. Added cases to the json test cases. In addition, added a
new unit tests that check if the opcodes behave in the expected way
in a large variety of situations.

Co-authored-by: Joshua Yabut <yabut.joshua@gmail.com>
Co-authored-by: Marcos Mayorga <mm@mm-studios.com>
Co-authored-by: Daniel Connolly <daniel@dconnolly.com>
Co-authored-by: Shammah Chancellor <shammah.chancellor@bitcoinabc.org>

Test Plan: make check

Reviewers: #bitcoin_abc, jasonbcox, schancel

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: jasonbcox, teamcity

Maniphest Tasks: T304

Differential Revision: https://reviews.bitcoinabc.org/D1211

Details

Provenance
deadalnixAuthored on Mar 19 2018, 10:42
deadalnixPushed on Mar 19 2018, 10:50
Reviewer
Restricted Project
Differential Revision
D1211: Add support for AND, OR and XOR opcodes
Parents
rSTAGINGa635b73ad81d: Add function to trim leading array zeros maintaining MSB.
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/3315, tag: phabricator/base/3307, tag: phabricator/base/3306, tag: phabricator/base/3305