HomePhabricator

Merge #13861: test: Add testing of value_ret for SelectCoinsBnB

Description

Merge #13861: test: Add testing of value_ret for SelectCoinsBnB

Summary:
384273260a6ccbcf79dade0830011f528e5a1581 test: Add testing of value_ret for SelectCoinsBnB (Ben Woosley)

Pull request description:

Fix that the early bailout optimization tests did not test the intended
selection because their utxo pool was polluted by the make_hard_case test
preceding. Note the code was tested, just not with the constructed case.

Tree-SHA512: 95f665525f5922f70f4c17708c0c09900f38d7a652b5bdd817e017ba7ff2865a6234edbd340064ffccc20d34048c45df86a4ac5f46dd8f4aab98834e71dc9d3c

Backport of Core PR13861
https://github.com/bitcoin/bitcoin/pull/13861/

Test Plan:

ninja check

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D4963

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Aug 27 2018, 10:44
nakihitoCommitted on Jan 16 2020, 21:30
nakihitoPushed on Jan 16 2020, 22:49
Reviewer
Restricted Owners Package
Differential Revision
D4963: Merge #13861: test: Add testing of value_ret for SelectCoinsBnB
Parents
rSTAGING4587adbf508b: [secp256k1] [ECDH API change] Support custom hash function
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/15540, tag: phabricator/base/15537