HomePhabricator

json: fail read_string if string contains trailing garbage
4e157fc60daeUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

json: fail read_string if string contains trailing garbage

Change read_string to fail when not the entire input has been
consumed. This avoids unexpected, even dangerous behavior (fixes #6223).

The new JSON parser adapted in #6121 also solves this problem so in
master this is a temporary fix, but should be backported to older releases.

Also adds tests for the new behavior.

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Jun 3 2015, 07:42
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGINGf00b62391b93: Merge pull request #6203
Branches
Unknown
Tags
Unknown

Event Timeline

Wladimir J. van der Laan <laanwj@gmail.com> committed rSTAGING4e157fc60dae: json: fail read_string if string contains trailing garbage (authored by Wladimir J. van der Laan <laanwj@gmail.com>).Jun 3 2015, 10:18