HomePhabricator

Updated to allow macOS build
539160cd04ceUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Updated to allow macOS build

Summary: The existing Bitcoin ABC code would not compile on macOS. It appears to be related to Boost. Adding "const" to a few lines in miner.h and txmempool.h allowed the build process to proceed. This change is consistent with a change performed on Bitcoin Core (https://github.com/bitcoin/bitcoin/pull/12032/files). Make boost::multi_index comparators const.

Test Plan: Confirm the changes allow the build process to proceed as desired on Linux/Windows

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix, BMahon9

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D855

Details

Provenance
BMahon9Authored on Jan 2 2018, 23:03
schancelCommitted on Jan 2 2018, 23:06
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Reviewer
Restricted Owners Package
Differential Revision
D855: Updated to allow macOS build
Parents
rSTAGING6726ab1decb2: Autopep8 test/functional/test_runner.py
Branches
Unknown
Tags
Unknown