HomePhabricator

Move finalization suck as reconsiderblock actualy reconsider blocks

Authored by deadalnix on Nov 22 2018, 16:12.

Description

Move finalization suck as reconsiderblock actualy reconsider blocks

Summary:
Right now, if we reconsider a block that has been excluded due to finalization, this block will immediately get excluded again and not actually be reconsidered.

To ensure it is, move the finalization to the last common ancestor betweent he finalized block and the reconsidered block before reconsidering.

Test Plan: Added integration test.

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D2118

Details

Committed
deadalnixNov 22 2018, 17:36
Pushed
deadalnixNov 22 2018, 18:22
Reviewer
Restricted Project
Differential Revision
D2118: Move finalization suck as reconsiderblock actualy reconsider blocks
Parents
rSTAGING0f56a224223d: Fix various bugs in the seeder.
Branches
Unknown
Tags
Unknown