HomePhabricator

fix some tests that misuse MANDATORY_SCRIPT_VERIFY_FLAGS

Description

fix some tests that misuse MANDATORY_SCRIPT_VERIFY_FLAGS

Summary:
MANDATORY_SCRIPT_VERIFY_FLAGS only exists to affect the banning behaviour
in AcceptToMemoryPool for transactions that fail to pass standard flags.
Since these tests are not about what kinds of script failures are
bannable / not bannable, they shouldn't care about what is in
MANDATORY_SCRIPT_VERIFY_FLAGS. (and such banning behaviour should in fact
be tested in the functional tests)

(cf: in Core, this flagset is only used in policy.h)

Test Plan: make check

Reviewers: Mengerian, #bitcoin_abc, deadalnix, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D4705

Details

Provenance
Mark Lundeberg <markblundeberg@users.noreply.github.com>Authored on Dec 12 2019, 01:36
FabienPushed on Dec 17 2019, 07:42
Reviewer
Restricted Project
Differential Revision
D4705: fix some tests that misuse MANDATORY_SCRIPT_VERIFY_FLAGS
Parents
rSTAGING387c0d235a92: Sanity check for mempool acceptance when doing standardness checks
Branches
Unknown
Tags
Unknown