HomePhabricator

Do not shadow variables (gcc set)

Description

Do not shadow variables (gcc set)

Summary:

  • Do not shadow variables (gcc set)
  • Check and enable -Wshadow by default.

This is a backport of core PR8808

Test Plan:

make check

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: jasonbcox, teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1866

Details

Provenance
Pavel Janík <Pavel@Janik.cz>Authored on Nov 10 2016, 07:00
deadalnixCommitted on Oct 3 2018, 12:08
deadalnixPushed on Oct 3 2018, 12:45
Reviewer
Restricted Project
Differential Revision
D1866: Do not shadow variables (gcc set)
Parents
rSTAGING568780144818: Fix numerous declaratiosn shadowing others
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/5243, tag: phabricator/base/5242