HomePhabricator

Avoid advertising the node's address when it is not listening or…
5d1b8f1725f5Unpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Avoid advertising the node's address when it is not listening or IsInitialBlockDownload().

This also avoids flushing setAddrKnown until 24 hours has passed,
and avoids contacting the external IP services when not listening.

Advertising non-listening nodes is just addr message spam.
It doesn't help the network, in fact it hurts the network,
and it also hurts user's privacy.

Advertising far out of sync nodes doesn't help the network—
they can't even forward (most) transactions and wastes nodes
outbound slots.

Details

Provenance
Gregory Maxwell <greg@xiph.org>Authored on Feb 1 2012, 23:08
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGINGd2291cce9235: Remove loose amp; from Portugese translation (issue #701)
Branches
Unknown
Tags
Unknown

Event Timeline

Gregory Maxwell <greg@xiph.org> committed rSTAGING5d1b8f1725f5: Avoid advertising the node's address when it is not listening or… (authored by Gregory Maxwell <greg@xiph.org>).Feb 1 2012, 23:08