HomePhabricator

[tests] Update start/stop node functions to be private module functions

Description

[tests] Update start/stop node functions to be private module functions

Summary:
This commit marks the start/stop functions in util.py as private module
functions. A future PR will remove these entirely and move the
functionality directly into the BitcoinTestFramework class, but setting them as
private in this PR will prevent anyone from accidentally calling them
before that future PR is merged.

This ends the backport of core's PR10359

This was also amended to prt the test thatare specific to ABC.

Depends on D991
Closes T149

Test Plan:

make check
./test/functional/test_runner.py --extended

Reviewers: #bitcoin_abc, matiu

Reviewed By: #bitcoin_abc, matiu

Subscribers: matiu, teamcity

Maniphest Tasks: T149

Differential Revision: https://reviews.bitcoinabc.org/D992

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on May 8 2017, 15:04
deadalnixCommitted on Jan 21 2018, 23:30
deadalnixPushed on Jan 22 2018, 00:44
Reviewer
Restricted Project
Differential Revision
D992: [tests] Update start/stop node functions to be private module functions
Parents
rSTAGING3f7c77c137e9: Fix build without wallet and with Qt enabled
Branches
Unknown
Tags
Unknown
Tasks
T149: Backport of Core PR 10171: [tests] Add node methods to test framework