HomePhabricator
Diffusion Bitcoin ABC staging 6050ab685553

netbase: Make SOCKS5 negotiation interruptible
6050ab685553Unpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

netbase: Make SOCKS5 negotiation interruptible

Avoids that SOCKS5 negotiation will hold up the shutdown process.

  • Sockets can stay in non-blocking mode, no need to switch it on/off anymore
  • Adds a timeout (20 seconds) on SOCK5 negotiation. This should be enough for even Tor to get a connection to a hidden service, and avoids blocking the opencon thread indefinitely on a hanging proxy.

Fixes #2954.

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Sep 8 2014, 11:49
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGING6a8d15cc1687: Merge pull request #4874
Branches
Unknown
Tags
Unknown

Event Timeline

Wladimir J. van der Laan <laanwj@gmail.com> committed rSTAGING6050ab685553: netbase: Make SOCKS5 negotiation interruptible (authored by Wladimir J. van der Laan <laanwj@gmail.com>).Sep 10 2014, 09:33

Changes (2)

PathSize
src/

rSTAGING6050ab685553

View Options

src/net.cpp

Loading...
View Options

src/netbase.cpp

Loading...