HomePhabricator

[refactor multisig] remove redundant counters

Description

[refactor multisig] remove redundant counters

Summary:
This is perhaps debatable but the ikey, isig indices are always intended
to iterate in step with the number of remaining objects, and the numbers
remaining are the important values needed to know when to stop iteration.
The ikey, isig thus only serve to avoid some (fast) arithmetic.

Depends on D3625

Test Plan: make check

Reviewers: deadalnix, #bitcoin_abc, Mengerian

Reviewed By: deadalnix, #bitcoin_abc, Mengerian

Subscribers: Mengerian

Differential Revision: https://reviews.bitcoinabc.org/D3675

Details

Provenance
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>Authored on Jul 15 2019, 01:02
nakihitoPushed on Jul 16 2019, 22:34
Reviewer
Restricted Project
Differential Revision
D3675: [refactor multisig] remove redundant counters
Parents
rSTAGING47756d0eea51: [2 of 5] validation: Extract basic block file logic into FlatFileSeq class.
Branches
Unknown
Tags
Unknown

Event Timeline

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rSTAGING637c25c0bc00: [refactor multisig] remove redundant counters (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).Jul 16 2019, 20:22