HomePhabricator

tweak auto-unparking message

Description

tweak auto-unparking message

Summary:

  1. UnparkBlock will only get called once per chain, i.e., we only see one

log message regardless of how many blocks got unparked on that chain,
since UnparkBlock will unpark all ancestors of pindexTest and it
results in everything from genesis to pindexNew being unparked. So
"unpark chain" rather than "unpark block" makes more sense as a message,
as I'd expect to see the latter one for every single block.

  1. Ideally when this message happens we should be in a state where

pindexNew == pindexTest, however it might somehow happen that this
isn't the case and we should print the tip of the chain that is being
unparked.

Test Plan: ninja check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D4937

Details

Committed
Mark Lundeberg <markblundeberg@users.noreply.github.com>Jan 18 2020, 05:06
Pushed
markblundebergJan 18 2020, 11:02
Reviewer
Restricted Project
Differential Revision
D4937: tweak auto-unparking message
Parents
rSTAGINGbaa19d9fb063: [validation.cpp] parking-related comment tweaks
Branches
Unknown
Tags
Unknown

Event Timeline

Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rSTAGING638e4857a2c4: tweak auto-unparking message (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).Jan 18 2020, 05:06