HomePhabricator

Don't retry a failing IRC nickname forever.
6a60c64c6b4cUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Don't retry a failing IRC nickname forever.

If our IRC nick is in use (because some other node thinks it has
the same address we think we have) don't fruitlessly try to reconnect
using that name forever. After three tries, give up and use a random
nick. Either we'll learn a new local address from IRC and switch
to that, or it was right and the other guy is advertising for us.

This avoids a pessimal case where a second testnet node behind
a nat is unable to get any peers because he can't get on IRC.

Details

Provenance
Gregory Maxwell <greg@xiph.org>Authored on Aug 29 2012, 02:04
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGING3595b18793a9: Don't force IRC off if not listening, do force it off if IPv4 is off.
Branches
Unknown
Tags
Unknown

Event Timeline

Gregory Maxwell <greg@xiph.org> committed rSTAGING6a60c64c6b4c: Don't retry a failing IRC nickname forever. (authored by Gregory Maxwell <greg@xiph.org>).Aug 29 2012, 02:04